Desbeers
commented
1 year ago Thanks for your pull-request; a very useful addition!
The 'define parser' works great!
However, a few issues:
- The macOS target does not compile because it's missing your new ChordPosition extension file. The 'QLextension' is not part of the 'Target Membership'.
- If you use a 'custom chord', the base name will be used in the song view because 'major' is the default suffix in the 'processChord' function. It will always be found. That 'base chord' is also added to the chord list.
- A 'custom define' will not override a default define; it will be added. It should override it in my opinion.
- When you click on a 'custom define' it will not find it and will show the 'C' chords instead, because that's the fallback (lazy code from my side, haha!).
- The first found chord is not used anymore as the key when the key is not set manually.
I would really like to merge this when above is fixed. Would you like to work on that or shall I merge it 'as is' and take it from there?
SaschaMzH
With this implementation, the chords that can be defined in the editor are also displayed correctly. Unfortunately, a small modification had to be made to the self-defined chord. The chords are no longer recognized by their key and suffix but stored directly in it. Afterwards the class ChordPosition of SwiftyChords could be extended by a new constructor which also allows own chords. Finally the view was extended so that only chords with finger definition are displayed if they are present.