search

Desbeers / Chord-Provider

A ChordPro file parser and editor for macOS Sonoma. Show the song with the chords for guitar, guitalele or ukulele and export them to PDF.
https://desbeers.github.io/Chord-Provider/
GNU General Public License v3.0
68 stars 9 forks source link

end_of_xxx not used #9

Closed SaschaMzH closed 1 year ago

SaschaMzH commented 1 year ago

It seams that there is a little bit magic because the end_of_xxx statements are not implemented. This should be implemented to be more specific and ChordPro conform.

Desbeers commented 1 year ago

Good point and a lot of magic!

When I wrote Chord Provider it was just to make my cut/paste from internet reasonable. A bit of auto-detection. Later ; I added ChordPro directives; when I needed it.

It will look at every paragraph and makes a 'magic' dissision.

I will work on this; a bit of 'magic' will stay unless the magic is not not needed...

Desbeers commented 1 year ago

Fixed in https://github.com/Desbeers/Chord-Provider/commit/9e2f975b665063a8b1e860c6e3fb79bd52d48e85