Desbeers / ChordProMac

A SwiftUI wrapper for the ChordPro program
MIT License
3 stars 0 forks source link

ChordPro for Apple Silicon #1

Open Desbeers opened 3 weeks ago

Desbeers commented 3 weeks ago

Make it my own issue, so it is not polluting the official ChordPro repo...

Please keep any issues with the builds here :-)

Currently, it is a dirty workaround; let's see if we can improve it!!

vermelho59 commented 3 weeks ago

I installed without any trouble. The script was a clean one shot deal. I have had to codesign apps in the past, but this made that and the install easy. I played around with a few different ChordPro files I have here, maybe not all kosher. Comments: I wish changes in the editor weren't automatically saved to the file on closing. I was trying a few experimental edits to see how they work, and inadvertently lost the original. Musejazz built-in config failed. The log showed missing fonts. Not sure where it's looking, and recall this issue being discussed in recent days. I couldn't get the transcode notation to work - this might have been issues with the .cho files I was trying.

The pdf example of output from your previous program looked really nice - will you have a custom config similar to that?

Have to move on to some other tasks, but I'll try to spend more time with it later.

Desbeers commented 3 weeks ago

Thank you (VERY) much for trying; it motivates me to stay on my beloved mac and not trowing the towel in the ring :-)

I look into that ‘auto-save’ issue, I sincerely dislike it and thought was disabled...

What do you mean with ‘previous program’? If you mean my ‘Chord Provider’; that is not my previous; that my current! I volunteered to ChordPro because I thought it was an easy thing to give back...

Well, not so... Johan helped me for a ChordPro config that was a bit similar but by far not the same.

I just like programming and both applications will learn from each other. They live in a different world. ChordPro is my challenge; Chord Provider is my Swifty Comfort Zone :-D

And yeh, there is a font issue... Transcode should be ok.

Thanks!

vermelho59 commented 3 weeks ago

Left it running, and things were getting a bit choppy. I think there might be memory leak... Screenshot 2024-08-28 at 8 30 21 PM

Desbeers commented 3 weeks ago

Nah, its just repeating the chorus!

Just kidding, on the list...

Desbeers commented 3 weeks ago

I wish changes in the editor weren't automatically saved to the file on closing.

I don’t have any control over this very annoying ‘feature` in the application; but the good news is that is is a system-wide setting:

Screenshot 2024-08-29 at 15 15 26
Desbeers commented 3 weeks ago

Left it running, and things were getting a bit choppy. I think there might be memory leak...

This is a very difficult one for me. Swift is a very ‘high level’ programming language that does not need any direct memory management.

In what state did you left it running?

I will leave a window open as well for a while to see whats happening...

Desbeers commented 3 weeks ago

Musejazz built-in config failed. The log showed missing fonts. Not sure where it's looking, and recall this issue being discussed in recent days.

Looking at the musejazz.json config; it expects you do download a font and place it in /.fonts

"fontdir" : [ "~/.fonts" ],
"fonts" : {
    "chord" : {
    "file" : "MuseJazzText.otf",
    },
    "diagram" : {
    "file" : "MuseJazzText.otf", "size" : 12,
    },
},

It does work when I download the font and place it in /Users/Desbeers/Library/Containers/ChordPro/Data/.fonts

(thats the home directory of a signed and sandboxed application; replace Desbeers with your name).

I consider this a ChordPro bug; build-in templates should work ‘out of the box’.

Desbeers commented 3 weeks ago

Oh, ok, I saw that the musejazz.json is not part of the official distribution :-)

I build my package straight from the source; Johan does that differently.

Desbeers commented 3 weeks ago

See https://github.com/ChordPro/chordpro/issues/413#issuecomment-2318141334

(fixed now)