DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.74k stars 231 forks source link

Remove DDAccess.h header, and associated DD_ACCESS_RING definition #342

Closed Lgt2x closed 2 months ago

Lgt2x commented 2 months ago

Pull Request Type

Description

This definition was used to control the accessibility of some class members, changing protected qualifiers to public. This introduced unnecessary coupling between components and headers.

All conditional access specifiers have been set to public, which should not be a problem given the low number of classes that actually used affected members. Another albeit more complex solution could have been to use friend classes.

Related Issues

Screenshots (if applicable)

Checklist