Fixed double delete/free in rend_Screenshot().

[pzychotic]

Pull Request Type

• [ ] GitHub Workflow changes
• [ ] Documentation or Wiki changes
• [ ] Build and Dependency changes
• [x] Runtime changes
  • [x] Render changes
  • [ ] Audio changes
  • [ ] Input changes
  • [ ] Network changes
  • [ ] Other changes

Description

I got crashes when saving Savegames on Windows in rend_Screenshot() that are introduced with 80c207d.

The auto screenshot in the beginning of that function is a std::unique_ptr<NewBitmap>. The following auto *temp_data is a raw pointer to NewBitmap::_data which itself is a std::unique_ptr. So the mem_free(temp_data) at the end of that function was freeing the memory held by _data and the auto screenshot going out of scope after that, was trying to delete that memory again through the dtor of the std::unique_ptr.

Related Issues

Screenshots (if applicable)

Checklist

• [x] I have tested my changes locally and verified that they work as intended.
• [x] I have documented any new or modified functionality.
• [x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• [x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

[JeodC]

I'll have to try this tonight, I didn't get any crashes when testing png on windows--and I used a savegame.