Windows x64 build

[pzychotic]

Pull Request Type

• [ ] GitHub Workflow changes
• [ ] Documentation or Wiki changes
• [x] Build and Dependency changes
• [x] Runtime changes
  • [ ] Render changes
  • [ ] Audio changes
  • [ ] Input changes
  • [ ] Network changes
  • [x] Other changes

Description

Getting this out as a starting point for a possible Windows x64 build.

So far my local tests in Singleplayer work fine. I haven't tried any Multiplayer.

Quick summary:

• DirectX SDK updated with x64 support
• Prevent 32bit truncations of WinApi types
• Compilation of scripts and netgames projects

Cut corners:

• Disabled callstack and exception info logging: https://github.com/DescentDevelopers/Descent3/pull/354/commits/caf19810158723708ac93dbf1880148c132f5a1d
  • Maybe this can be replaced with writing a MiniDump file nowadays? Done in #514
• Disabled some code for 'mono' debugger: https://github.com/DescentDevelopers/Descent3/pull/354/commits/bac882c7d6a47e3ec990be25dd339101115cef09
  • Do we even still need this? Code removed in #410

Open questions:

• I had to load the new d3-win.hog last so the x64 DLLs from it will be found before the x86 DLLs from the original game data: https://github.com/DescentDevelopers/Descent3/pull/354/commits/435b1f48bb101295d868b426a4de3ec8edf53378
  • Shouldn't this also be done for Linux/Mac? Done in https://github.com/DescentDevelopers/Descent3/pull/354/commits/0c67b093c637d41d964e540cced5049851db29f0
• Array access with negative index in dsound3d.cpp only crashes in x64: https://github.com/DescentDevelopers/Descent3/pull/354/commits/11af2e7ec0540001e023f8380aa8491773d09460
  • This problem is already present in x86 builds, but doesn't crash...

Known Issue:

• Savegames from 32bit and 64bit versions aren't compatible: https://github.com/DescentDevelopers/Descent3/discussions/366

Checklist

• [x] I have tested my changes locally and verified that they work as intended.
• [x] I have documented any new or modified functionality.
• [x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• [x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

[Lgt2x]

Hey, that looks promising! Just so you know, we will be working on replacing DirectX with SDL2 on Windows just like Linux and MacOS do, so don't spend too much effort on the DirectX code

[pzychotic]

Hey, that looks promising! Just so you know, we will be working on replacing DirectX with SDL2 on Windows just like Linux and MacOS do, so don't spend too much effort on the DirectX code

Thanks for the heads-up on DirectX stuff. I wasn't planning spending time on it, just replaced the SDK for the x64 support to get the current stuff to compile and run.

[MaddTheSane]

• I had to load the new d3-win.hog last so the x64 DLLs from it will be found before the x86 DLLs from the original game data:pzychotic@435b1f4

  • Shouldn't this also be done for Linux/Mac?

Maybe for Linux, but macOS can have multiple architectures in one binary.

[JeodC]

I can't review further, other than verifying it works in windows, but I'd like to note that as pzychotic nicely explained, this pull will resolve the outstanding multiplayer issues.

[pzychotic]

We need additionally mention somewhere that we use static DirectX libraries (and here issue about licensing them with GPLv3 code).

These are not static libraries, these are just the link libs needed by the linker to resolve the symbols to the DLLs.