DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.86k stars 245 forks source link

Utilize Windows types #357

Closed GravisZro closed 4 months ago

GravisZro commented 4 months ago

For whatever reason they decided to switch a bunch of Windows types to their underlying types which causes problems when replacing possibly problematic 32-bit long types. This restores the use of the Windows defined types.

Pull Request Type

Description

This is a type refactor, it doesn't impact how the code behaves.

Related Issues

Screenshots (if applicable)

Checklist

Additional Comments

Presently no overlap with PR #354

GravisZro commented 4 months ago

@Lgt2x My PRs are always treated like they are second-class. Everything else gets reviewed and merged before mine and then I have to fix my PRs repeatedly.

Lgt2x commented 4 months ago

@Lgt2x My PRs are always treated like they are second-class. Everything else gets reviewed and merged before mine and then I have to fix my PRs repeatedly.

I'm really sorry you feel that way; I tried to review PRs by order of creation yesterday. Your contributions are always welcome and very appreciated, I follow the same standards for every review.