Fixed missing initialization of m_MsgFn array in ctor - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.86k stars 245 forks source link

Fixed missing initialization of m_MsgFn array in ctor #368

Closed pzychotic closed 4 months ago

pzychotic commented 4 months ago

Pull Request Type

[ ] GitHub Workflow changes
[ ] Documentation or Wiki changes
[ ] Build and Dependency changes
[x] Runtime changes
- [ ] Render changes
- [ ] Audio changes
- [ ] Input changes
- [ ] Network changes
- [x] Other changes

Description

The array oeWin32Application::m_MsgFn was never initialized and therefor calls to oeWin32Application::add_handler(...) might fail to find an empty slot in that array because of the uninitialized memory.

Related Issues

This might fix the IO init problem mentioned in https://github.com/DescentDevelopers/Descent3/issues/217#issuecomment-2104805603. Because the mouse code might fail to add the RawInputHandler at https://github.com/DescentDevelopers/Descent3/blob/56e61275ce3209d2d69b895d5809e4089def0851/ddio_win/winmouse.cpp#L452

Screenshots (if applicable)

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[x] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments