Clean a few warnings - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.74k stars 231 forks source link

Clean a few warnings #382

Closed JeodC closed 1 month ago

JeodC commented 1 month ago

Pull Request Type

[ ] GitHub Workflow changes
[ ] Documentation or Wiki changes
[x] Build and Dependency changes
[ ] Runtime changes
- [ ] Render changes
- [ ] Audio changes
- [ ] Input changes
- [ ] Network changes
- [ ] Other changes

Description

Remove unused declarations
Add braces to controlled statement
Remove negates in .gitignore for specific vscode files

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[ ] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Tested build in windows, no differences in runtime.

JeodC commented 1 month ago

I took the opportunity to fix my previous errors in formatting in init.cpp. I wasn't sure if we had a preference for else statements. In VSCode separating them from the close bracket looked neater to me, but I will revert that if we have a different standard.