DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.85k stars 244 forks source link

Use static versions of dependencies linked through vcpkg #430

Closed pzychotic closed 3 months ago

pzychotic commented 3 months ago

Pull Request Type

Description

Revisiting the conversation in #319 trying to follow up on the point I raised concerning the CRT linkage, I realized one of the first questions asked was if we can just link all vcpkg dependencies statically (before that whole conversation got sidetracked to pointless license discussions). Since vcpkg already has a triplet for static ports using dynamic CRT linkage, this will just do that.

Related Issues

Screenshots (if applicable)

Checklist

Additional Comments

If we go for this PR instead of #319, we should still take the change from 8f670d7f0d95ea38fa7efb369394d947070251fb of that PR. Already in main as part of 82c04f8fb925f74ac045b5c4510d890ecfbf19c8.