Add 1920x1080 resolution supoort - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.73k stars 231 forks source link

Add 1920x1080 resolution supoort #439

Open jopadan opened 2 weeks ago

jopadan commented 2 weeks ago

Pull Request Type

[ ] GitHub Workflow changes
[ ] Documentation or Wiki changes
[ ] Build and Dependency changes
[x] Runtime changes
- [x] Render changes
- [ ] Audio changes
- [ ] Input changes
- [ ] Network changes
- [ ] Other changes

Description

Add 1920x1080 resolution support affecting #205

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[x] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

JeodC commented 2 weeks ago

Adding widescreen resolutions into the game settings should come with handling the aspect ratio as well. It's a bit more than just adding resolutions to the list--which, if you do, you risk that list overflowing and rendering oddly.

For now you should be using the commandline arguments -width 1920 -height 1080 -aspect 1.78