DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.73k stars 231 forks source link

Remove the CD-ROM asset loading logic and -cdrom option #452

Closed Lgt2x closed 1 week ago

Lgt2x commented 1 week ago

Pull Request Type

Description

CD-ROM code needs specific hardware to be tested and maintained, and does not fit with the modernization this project envisions. I doubt the Mac hardware we now target have built-in CDrom readers anymore.

To play using data from a CD-ROM, it needs to be mounted, and the mount address to be provided to the -setdir argument

winterheart commented 1 week ago

There also GetMultiCDPath() function that can be removed.

Overall PR is good, tested on Linux, no problems spotted.

Lgt2x commented 1 week ago

There also GetMultiCDPath() function that can be removed.

Overall PR is good, tested on Linux, no problems spotted.

In my understanding GetMultiCDPath does more than retrieve from a CD, it's a generic file loader. You've edited this function yourself recently. It can maybe be renamed though