Define OutrageMessageBox regardless of DEBUG

[tophyr]

Pull Request Type

• [ ] GitHub Workflow changes
• [ ] Documentation or Wiki changes
• [ ] Build and Dependency changes
• [x] Runtime changes
  • [ ] Render changes
  • [ ] Audio changes
  • [ ] Input changes
  • [ ] Network changes
  • [x] Other changes

Description

OutrageMessageBox() doesn't depend on anything debug-specific - it appears to be conditionally-defined basically just to avoid interrupting the user in release builds. However, the codebase appears to think that DEBUG and RELEASE are perfect opposites, which is not true. (The RelWithDebInfo build, in particular, has neither set.)

Here we define OutrageMessageBox regardless of build type, and let the RELEASE check determine whether or not it wants to interrupt the user.

Checklist

• [x] I have tested my changes locally and verified that they work as intended.
• [x] I have documented any new or modified functionality.
• [x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• [x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

[tophyr]

Better fix that does not require compile-time conditionals: Define OutrageMessageBox functions for non-debug builds with empty function body in error.cpp, and remove all compile guards on function usage

re-worked. i didn't go with the empty body, because the body appears to be there either way already. the RELEASE checks appear to be primarily to avoid string calculations when unnecessary.