DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.73k stars 231 forks source link

use in-tree SDL #466

Closed tophyr closed 1 week ago

tophyr commented 1 week ago

Pull Request Type

Description

Use SDL as a git submodule, and incorporate the project directly into our build instead of relying on a prebuilt library provided by a package manager or system configuration. This will enable us to build SDL precisely to our needs, for our build target.

Checklist

tophyr commented 1 week ago

Will need reconciliation with #457

Lgt2x commented 1 week ago

why not using VCPKG? And we probably don't want SDL unstable master branch

Lgt2x commented 1 week ago

As discussed on Discord, I'd prefer a unified VCPKG-based solution for our external packages. We don't have a tangible reason to require a personalized (and master branch) SDL2 build right now. VCPKG can apparently be used for Android, and compile libraries in debug mode if we need to.