Isolate misc module - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.73k stars 231 forks source link

Isolate misc module #470

Closed winterheart closed 6 days ago

winterheart commented 1 week ago

Pull Request Type

[ ] GitHub Workflow changes
[ ] Documentation or Wiki changes
[x] Build and Dependency changes
[ ] Runtime changes
- [ ] Render changes
- [ ] Audio changes
- [ ] Input changes
- [ ] Network changes
- [ ] Other changes

Description

Isolate misc module for better dependency handling. This change needed for upcoming cfile unittest framework.

Related Issues

Screenshots (if applicable)

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[x] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

winterheart commented 6 days ago

Probably yes. I think logging facility would be header-only macros. Error handling troubles me - it requires SDL for SDL_Assert() and effectively pulls it to all dependent modules.