Fix deprecation warning about /Zc:forScope- - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.73k stars 231 forks source link

Fix deprecation warning about /Zc:forScope- #479

Open winterheart opened 3 days ago

winterheart commented 3 days ago

Pull Request Type

[ ] GitHub Workflow changes
[ ] Documentation or Wiki changes
[x] Build and Dependency changes
[ ] Runtime changes
- [ ] Render changes
- [ ] Audio changes
- [ ] Input changes
- [ ] Network changes
- [ ] Other changes

Description

/Zc:forScope- was used in old MSVC versions that allows reusing initialized in loops variables outside of these loops. Now this option is deprecated and may be removed in future versions of MSVC (see https://learn.microsoft.com/en-us/cpp/build/reference/zc-forscope-force-conformance-in-for-loop-scope). Fixed out-of-scope variables usage.

Related Issues

Screenshots (if applicable)

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[x] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments