Resolve out-of-bounds accesses with dedicated server code [ASAN]

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.88k stars 251 forks source link

Closed jengelh closed 2 months ago

jengelh commented 2 months ago

Fixes some of the issues plaguing #571.

[x] I have partially tested my changes locally and verified that they work as intended.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Lgt2x commented 2 months ago

Possible concurrent changes with #578 published 6 minutes apart, needs sync with @winterheart :)

jengelh commented 2 months ago

In my defense, the introductory comment “What's the content...” effectively was a self-assign before the assigner field was actually set ;-)

winterheart commented 2 months ago

Let's just change server_config_name to std::filesystem::path and add path existence of it, and we'll be fine.

jengelh commented 2 months ago

Sounds very sensible.

winterheart commented 2 months ago

Tested on prepared environment, fixes #571.