DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.88k stars 251 forks source link

Merge WinController and lnxcontroller #589

Closed Lgt2x closed 2 months ago

Lgt2x commented 2 months ago

Pull Request Type

Description

Rework the controller module: merge lnx and win controller implementations to make sdlcontroller, improve the module interface, move it to DDIO, remove cruft.

Checklist

Additional Comments

Tested in-game controller support on Win11 and Arch.

0xFADDAD commented 2 months ago

Seems like a good enough place to ask, but is there any possibility of restoring force feedback effects for joysticks? It might be a bit of work to translate the haptic effects like sawtooth and sine down to plain rumble for gamepads, but if it means adapting a bunch of DirectInput code to SDL2, I could understand leaving it out.

Lgt2x commented 2 months ago

Seems like a good enough place to ask, but is there any possibility of restoring force feedback effects for joysticks? It might be a bit of work to translate the haptic effects like sawtooth and sine down to plain rumble for gamepads, but if it means adapting a bunch of DirectInput code to SDL2, I could understand leaving it out.

Good idea, SDL2 apparently supports haptic devices, so it could be implemented again without too much trouble. I'd need hardware to test it though. Would you mind opening an issue in the tracker?

winterheart commented 2 months ago

Looks good, need to resolve conflicts first.

Lgt2x commented 2 months ago

rebased

winterheart commented 2 months ago

ready to go!