search

Deschtex / html2react

A utility for turning raw HTML into React elements.
MIT License
43 stars 5 forks source link

Upgrade dependencies and support React 16+ #27

Closed olofd closed 6 years ago

olofd commented 6 years ago

Upgraded all dependencies (And made sure that build and lib and tests still work) and added support for React 16.

Reason for change: As stated in #25, This library does make use of react-dom/lib/HTMLDOMPropertyConfig and react-dom/lib/SVGDOMPropertyConfig . These config's is no longer included/exposed by React, starting at React 16. We need these properties however, and others do to. So for now I've used this package: https://github.com/remarkablemark/react-dom-core that includes these properties to to be consumed from React 16 apps.

This package takes the old properties from 15 and includes them as an package. In the future we might want to include this list in this package to have it aligned with React 16m or take a different approach. But for now, this works well in React 16.

Deschtex commented 6 years ago

Thanks for helping out, @olofd. Yea, I'd like to not depend on that package, but we can merge this and I will inline the attributes in a future release.

olofd commented 6 years ago

@Deschtex Fixed. Will you tag and release after merge?

Deschtex commented 6 years ago

Thanks. Yes, I will tag and publish after it's merged.