search

Descolada / AHK-v2-libraries

Useful libraries for AHK v2
MIT License
94 stars 9 forks source link

Recent WinEvent.ahk changes causing side effects #11

Closed Tomshiii closed 4 months ago

Tomshiii commented 4 months ago

I'm not sure how to easily explain this, or really explain it in a way that might make sense but I'll try to do my best. I have a script that allows me to move the playhead within Premiere Pro using a mouse button. Within this script I also set two hotkeys so that clicking either LButton or XButton2 during the loop will change some class variables so that when RButton is released different things may happen.

Previously this worked no problem, but after the recent changes these values no longer get updated while WinEvent.NotActive is present. Removing that line alone (or reverting changes made to WinEvent in my repo) is the only way to return usual functionality.

The reason for things breaking as far as I can tell seems to be this change on line 313;

-this.pCallback := CallbackCreate(callbackFunc, "C", 7)
+this.pCallback := CallbackCreate(callbackFunc, "C Fast", 7)

Reverting this line alone seems to return previous functionality. I won't pretend to understand how that ties into the overall lib so if that's just how it's gotta be now then so be it feel free to let me know and I'll just freeze the previous version in my repo. Just thought I would mention it on the off chance that it's an avoidable scenario.

Thank you for your time and all the work you've put into this script! It's awesome. Let me know if there's anything else you might need from me, happy to help however I can.

Descolada commented 4 months ago

Thank you for reporting this! That was an accidental addition and shouldn't have been there, it has now been removed.