Not filtering degenerate data correctly.

DesignEngrLab / MIConvexHull

A .Net fast convex hull library for 2, 3, and higher dimensions.

http://designengrlab.github.io/MIConvexHull/

MIT License

338 stars 60 forks source link

Not filtering degenerate data correctly. #12

Closed JamieCox1995 closed 7 years ago

JamieCox1995 commented 7 years ago

Found that the FindInitialPoints() method in the ConvexHullAlgorithm.Initialize script, at line 500, was not correctly throwing an error when a degenerate set of data was found. We found that this was due to the conditional if the if statement " && IsLifted"

micampbell commented 7 years ago

That is correct. I'm a little bashful about that. Is it a hack? Well, most of the recent problems people have had point to problems with Delaunay triangulation on uniformly spaced points. This term "IsLifted" is intended to catch cases when an additional dimension is added for Delaunay and Voronoi. Instead of being degenerate and throwing an error, we deal with it and do an arbitrary initial triangulation of the simplex. Make sense? Do this answer your question, or does your problem persist?