DesignRevision / shards-react

⚛️A beautiful and modern React design system.
https://designrevision.com/downloads/shards-react/
MIT License
757 stars 97 forks source link

Fade Duration #20

Open machineghost opened 4 years ago

machineghost commented 4 years ago

First off let me just say that I <3 this library: it looks great, it's got some great basic utility functionality (but is still very minimal/lightweight), and it feels like a React library, not a UI library ported to React.

However, I have one minor request: the <Fade> component is great, but I feel like you can't even see a visible fade, so it's more like a visible/not visible component.

To be honest, I was kind of surprised to discover that even just that was pretty useful (I prefer using the tag to display style ternaries) ... but I feel like it would look a little cooler if I could somehow provide a prop to indicate "fade in 2x or 3x slower" (eg. fadeTime={300}).

And maybe consider upping the default time too? My perfect scenario would be to have a quick but visible fade happen by default without any props.

EDIT: After a browser restart (among other things) the fade started becoming obvious again. I'd still like a way to have a slightly longer fade, but I think the default time is fine.