DesignRevision / shards-react

⚛️A beautiful and modern React design system.
https://designrevision.com/downloads/shards-react/
MIT License
762 stars 98 forks source link

Allow tag to be a component #29

Open sammy2077 opened 4 years ago

sammy2077 commented 4 years ago

When i pass a component as a tag to supported element like Nav

import { Link } from 'react-router-dom';

<NavbarBrand tag={Link} to="/">
          Agweria
</NavbarBrand>

I get the error : Failed prop type: Invalid prop tag supplied to NavbarBrand See console error

image

Though it works fine even in the above case, is there a way to get rid of the console error.

See . https://github.com/facebook/prop-types/pull/211

jorgeotavio commented 4 years ago

I am also experiencing this problem, which happened when I upgraded React-router-dom to the latest version 5.1.2.

bvanhou commented 4 years ago

Anything updates on this? @design-revision