Fix checkbox & radio input elements

DesignRevision / shards-react

⚛️A beautiful and modern React design system.

https://designrevision.com/downloads/shards-react/

MIT License

759 stars 98 forks source link

Fix checkbox & radio input elements #6

Closed ZsharE closed 5 years ago

ZsharE commented 5 years ago

Bugs found:

nested <label> tags
duplicate id attribute for each control
missing control classes: d-block, my-2
adding events on labels
text label missing

zackphilipps commented 5 years ago

@hisk this looks pretty legit, when are you planning on testing/merging?

tstojecki commented 5 years ago

This is a bug indeed, thanks @ZsharE

zackphilipps commented 5 years ago

@hisk bump. We bought everything from Shards, which is supposed to include support. I reached out via support ticket to see if you could merge this PR. Any thoughts?

zackphilipps commented 5 years ago

Thanks for merging, @hisk!