search

DesignRevision / shards-react

⚛️A beautiful and modern React design system.
https://designrevision.com/downloads/shards-react/
MIT License
759 stars 98 forks source link

trying to import shards.scss with dart sass results in errors #9

Closed zackphilipps closed 5 years ago

zackphilipps commented 5 years ago 
 ERROR  Failed to compile with 1 errors                                                                      10:50:51 AM
⠀
 error  in ./src/components/layout.scss
⠀
Module build failed (from ./node_modules/sass-loader/lib/loader.js):

$popover-arrow-outer-width:           $popover-arrow-width + 1px !default;
                                     ^
      Incompatible units px and rem.
    ╷
759 │ $popover-arrow-outer-width:           $popover-arrow-width + 1px !default;
    │                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵

@tisk I'm happy to submit a PR for these errors if you're open to it.

zackphilipps commented 5 years ago

This was my fault, I was importing things in the wrong order.