search

DesignRevision / shards-vue

🌟Shards Vue is a free, beautiful and modern Vue.js UI kit based on Shards.
https://designrevision.com/docs/shards-vue/
MIT License
393 stars 40 forks source link

Incompatible units: 'px' and 'rem'. #14

Open lixaotec opened 5 years ago

lixaotec commented 5 years ago

Expected Behavior

Should Compile SCSS without issue

Current Behavior

Incompatible units: 'px' and 'rem'. SASS compiler error, regarding scss-shards-ui_variables.scss

It seems to happen when using operations like sum with valiables. $popover-arrow-outer-width: $popover-arrow-width + 1px !default;

Shouldnt be all measument of pixels converted to rem, as bootstrap4 standards? (Im not css expert, just wondering)

Thank you

lixaotec commented 5 years ago

Just read about funcion calc() , when applied it seems to superseed the error.

hisk commented 5 years ago

@lixaotec Thanks for submitting this! 😄This issue is caused due to version inconsistencies. Shards Vue is currently compatible with Bootstrap 4.1.3 while you are most probably using the latest version 4.2.1.

I am working towards updating all products, including Shards Vue to the latest version as soon as possible, however, I'm afraid I cannot provide an ETA just yet. My goal is to release the update early next month.

I apologize for the inconvenience.

lixaotec commented 5 years ago

Appreciate your response and work!

Indeed i´m using latest version.

I wish to take a part and ask about another aspect, why not using bootstrap-vue as basis for components instead of rewriting as you did? Just wondering the matters.

Thank you

hisk commented 5 years ago

@lixaotec That's a good question! I actually preferred writing my own library for multiple reasons.

First, I wanted to tackle a project like this on my own, mostly as a learning experience.

Another reason was that bootstrap-vue does not come with some custom components that were part of the base Shards framework and that would have required me to mix and match them in order to get the result I wanted. While that would have worked, I didn't find it ideal.

Finally, and most importantly, using their library meant that all the products I will build based on it would be influenced by the changes introduced inside the core bootstrap-vue framework. While from a maintainability point of view that would have been great (since I wouldn't have had to update the framework to the latest version of Bootstrap 4 and so on), I would have also been influenced by unexpected "3rd-hand" breaking changes. I know this might not sound critical right now, but in time, after more products will be released that are based on Shards Vue, the granular control I have over it will prove to be an advantage.