search

DesignRevision / shards-vue

🌟Shards Vue is a free, beautiful and modern Vue.js UI kit based on Shards.
https://designrevision.com/docs/shards-vue/
MIT License
393 stars 40 forks source link

Collapse Component wrong size prop for Button Component #16

Open MrWeb opened 5 years ago

MrWeb commented 5 years ago

In this page https://designrevision.com/docs/shards-vue/components/collapse there is a demo for the Collapse component showing a button with size="small". This returns an error: Invalid prop: custom validator check failed for prop "size"

In the Button Component the only allowed sizes are sm and lg as showing in button/Button.vue component line 56-60:

size: { type: String, validator: v => ['sm', 'lg', null].includes(v), default: null },

I propose we change size="sm" in https://designrevision.com/docs/shards-vue/components/collapse