search

DesignRevision / shards-vue

🌟Shards Vue is a free, beautiful and modern Vue.js UI kit based on Shards.
https://designrevision.com/docs/shards-vue/
MIT License
393 stars 40 forks source link

d-nav-item and d-link won't work with named routes #4

Closed St3Ko closed 5 years ago

St3Ko commented 5 years ago

first of all, thank you very much for this awesome ui kit!

Expected Behavior

the :to prop for d-nav-item and d-link should work like the same way router-link :to does. how they should work

Current Behavior

d-nav-item and d-link :to prop only accepts a string or an object with a path prop

Steps to Reproduce

  1. use a d-nav-item or d-link with a named route
  2. will produce href="#"

Context (Environment)

i mainly use named routes in my apps so this would be awesome if it would work

hisk commented 5 years ago

@St3Ko Thanks for taking the time to submit this Stefan! 😊I just noticed a major improper binding for the <d-link> component that caused this bug. I just submitted a fix for it and updated the package.

Please update to 1.0.3 and let me know how it goes.

St3Ko commented 5 years ago

Works like a charm now :) Thank you very much for this fast fix!