ripple button - Githubissues

DesignSystemsOSS / getbuttons.io

Love Buttons? Get so many button designs. Click Click!!

MIT License

12 stars 23 forks source link

ripple button #49

Closed akshatvirmani closed 3 years ago

akshatvirmani commented 3 years ago

Fixes #47 🔐

Are you a part of LGM SOC' 21 ❓

[x] Yes ✔️
[ ] No ✖️
Describe the changes you've made 🏆

Added ripple effect on clicking the button

Type of change 🖇️

Please delete options that are not relevant.

[ ] Bug fixing (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: 📋

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if required) 📷

Tested the effect on primary buttons.

https://user-images.githubusercontent.com/77536248/123125833-7fc06500-d466-11eb-815c-f78c6dffe0e1.mp4

yashsehgal commented 3 years ago

Good work @akshatvirmani 👍🏽 Just one more thing you have to do. Write the same code in the SCSS file as well ✅