[BUG] Header should not streatch to extreme sides

DesignSystemsOSS / thedesignsystems

Website for The DesignSystems (@DesignSystemsOSS)

https://www.thedesignsystems.com/

MIT License

7 stars 13 forks source link

[BUG] Header should not streatch to extreme sides #32

Open jayeshchoudhary opened 2 years ago

jayeshchoudhary commented 2 years ago

🙁 Actual behavior

Currently, app header is stretching to extreme sides. It should have some left and right padding to look good. also, there is way too much margin on top of the header.

🙂 Expected behavior

There should be some spacing around app header (left and right) also decrease top margin a bit.

🔢 Steps to Reproduce the Problem

go to home page and verify

yashsehgal commented 2 years ago

Well, it's due to different screen sizes. If you've made it work for all the possible screen widths then it's a great fix to be merged.

jayeshchoudhary commented 2 years ago

@yashsehgal It is present even for desktop screen I have created a PR for the same

yashsehgal commented 2 years ago

Please do refer to these changes - https://github.com/DesignSystemsOSS/thedesignsystems/pull/33#pullrequestreview-768573480