search

DesignSystemsOSS / thedesignsystems

Website for The DesignSystems (@DesignSystemsOSS)
https://www.thedesignsystems.com/
MIT License
7 stars 13 forks source link

Wrong Mapping of elements [BUG] mapping of elements in the footer section (usefullinks) is incorrect. #39

Open gunwant11 opened 2 years ago

gunwant11 commented 2 years ago

🙁 Actual behavior

I forked from the main branch and saw this error in my console while make the website responsive.

Screenshot (695)_LI

🙂 Expected behavior

later i tried to find the bug and found this.

Screenshot (698)

also this

Screenshot (700)

Clearly the mapping method is incorrect
in each iteration the same index was being used Also the json file was not framed properly

🔢 Steps to Reproduce the Problem

I have fixed this issue in my next pull request to the responsive branch😄. i guess this is the reason why vercel bot denyed the pull request of @Yash-Chauhan09 and others🙁. Pls fix this issue using my code or anything else its kinda demotivating when u get an error in pull request.

yashsehgal commented 2 years ago

Thanks for raising up this error in the Footer. You can definitely make a footer component responsive in a PR and fix the mapping issue in the other one. ⭐

And for the vercel deployment issue, It's just our team account has expired. You can refer to this comment