DesmondTo / pe

0 stars 0 forks source link

Allow adding potential similar staff to the system #1

Open DesmondTo opened 3 years ago

DesmondTo commented 3 years ago

Step to reproduce: Using the commands below:

  1. add n/Candice s/parttime p/91234567 $/2 e/candice@example.com
  2. add n/candice s/parttime p/91234567 $/2 e/candice@example.com

Expected:

  1. Not allow to add the second staff named candice, as it is very possible that she is the same person as Candice. Or at least give a warning.

Actual:

  1. Allow adding the staff that potentially to be the same staff. No warning.

image.png

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names that are of different case can still be added

Steps to Reproduce

1) add n/Candice s/parttime p/91234567 $/2 e/candice@example.com 2) add n/candice s/parttime p/91234567 $/2 e/candice@example.com

Expected

Program rejects duplicate person

Actual

Program accepts it. Maybe a check for case sensitivity would be better.

Screenshot

image.png

The user guide also mentioned this but the behaviour is different

image.png


[original: nus-cs2103-AY2122S1/pe-interim#3329] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The second image of the User Guide mentions that names ARE case sensitive, thus "candice" and "Candice" are accepted as two different people.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Although it is a duplicate, but still a valid bug. It should not be rejected.