search

DesmondTo / pe

0 stars 0 forks source link

Error of addshiftcommand sequence diagram #13

Open DesmondTo opened 3 years ago

DesmondTo commented 3 years ago

The lifeline of the :addShiftCommandParser is continued after the deletion of the class. Incorrect UML diagram. No note was stated if this is the limitation of the drawing tool below the diagram.

image.png

nus-pe-bot commented 3 years ago

Team's Response

I do not think that the end of the lifeline has to be at the end of the actvation bar, as object deletion does not occur immediately after the methods execution, and it is not significant enough to warrant a mention on the subject. It clearly does not affect the user sufficiently, and is reasonable given Java's garbage collection.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

"it is not significant enough to warrant a mention on the subject." But similar note is stated in your DG too. If it's insignificant, then I think should remove altogether? Also, if it is not a bug, then the original AB3 DG doesn't need to state it at the first place, but it still do. Hence, I think it's a bug that we need to take care of.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: image.png

It should not be VeryLow as it is not a cosmetic issue, but rather an correctness issue.