search

DesmondTo / pe

0 stars 0 forks source link

Name of the staff is allowed to be edited to unreasonably long name #3

Open DesmondTo opened 3 years ago

DesmondTo commented 3 years ago

Step to reproduce:

  1. Enter the command edit -i 7 n/ABCDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD

Expected: Limit the name to certain number of characters

Actual: Allow the name to be unreasonably long, which causes part of the name to be truncated.

image.png

nus-pe-bot commented 3 years ago

Team's Response

For the UI, shouldn't be considered a bug as it does not hinder the user: "The problem can hinder the user (e.g., not seeing the last part of a very long name might not hinder the user..." (From Textbook -> Bug Triaging -> Functionality bugs -> Problems caused by very long input values), there are enough characters shown that it does not fall under "only the first few characters of the name"

image.png

Otherwise, long name should be allowed as it while it isn't very common, there are people with very long names, and there's no benefit to restrict the input of such names.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]