Open dozer8383 opened 2 months ago
This is extremely interesting... The lines on borders when you move is just an artifact of temporal accumulation, as it has to reset the data in new areas being shown, not much can be done about that. But the fact that it's so bright and so green is definitely confusing. the whole image seems to be a lot more green than it should be. The only thing I can think of is that it's integrated, I really haven't seen anything like this...
Hah. Yeah, integrated graphics hardly play nicely with anything, but I've never had any problems with other shaders aside from just low FPS on the high settings. Oh well. Something about 0.4 Patch 3 made the shader load this time, all the other versions won't load, so you changed something that made it work (though, clearly, not correctly). Keep up the good work, maybe it'll fix itself.
Update: I tried setting Temporal Accumulation to OFF, and now everything is bright white except for the sky which appears moderately normal, and a small band at the bottom of the screen which just appears like an insanely oversaturated photo. When I press F1 to turn off the GUI, the white begins to form weird patterns with yellow, blue, and green, depending on the camera angle, and turning the GUI back on seems to pause it from changing colors. I tried turning Temporal Accumulation back to its default value and to a high value and now it won't go back to the green tinted, growing black lines phenomenon.
Hah. Yeah, integrated graphics hardly play nicely with anything, but I've never had any problems with other shaders aside from just low FPS on the high settings. Oh well. Something about 0.4 Patch 3 made the shader load this time, all the other versions won't load, so you changed something that made it work (though, clearly, not correctly). Keep up the good work, maybe it'll fix itself.
Strangely everything works fine for me on an Intel UHD Graphics integrated graphics card...
Minecraft: 1.21 Fabric: 0.16.0 Iris: 1.7.3 Sodium: 0.5.11
Hmm, yeah this shader seems kind of hit and miss with some people.
Update for 0.4 Patch 4: So, things are better but also not. No big bleeding black lines any more, but colors are still messed up. These are screenshots from a world (modded). One is without shaders and the other Phoxel. If I turn off the GUI when Phoxel is enabled, everything goes black, and while you can see the GUI fine if you enable it again, the world stays black. Only turning shaders off and back on will make it work again. Not sure if this will help at all, but thought I'd note it anyway.
It's almost like it's corrupted... I checked your IGPU's RAM and perhaps you don't have enough?, I feel as though it would just crash, but I don't know. The only way to tell is to check your VRAM usage. I do use a 2 high precision float vec4 buffers, along with 1 of them being possibly large in size, and another 2 large buffers for block textures.
So, I realized that 1.20.1 is not supported by patch 4 or 0.5.1, so now here's more updates, with the F3 screen open so you can see the system stats. It actually looks OK now. These screenshots are on 1.21.1 with Phoxel 0.5.1.
It looked fine, no severe discoloration (but no pathtracing goodness still), until I turned on panorama mode.
Putting it back to normal did not revert this.
It only got worse with time until it was basically a seizure waiting to happen. Thanks for all your support and work in investigating this.
Ok, so few helpful things I've noticed, which I'm going to mark here.
I will send a modified pack when I can with these changed in hopes of finding the issue. Thank you so much for your patience!
Thank you so much! I'm willing to wait a long time for this shader, I'm determined to finally get to use a real pathtracing shader. Not sure if it's just because its broken, but as the shader is currently, this is one of the more performant shaders for my computer. I'm getting 30-40 fps most of the time (which is more than can be said for Complementary on High preset). Also, getting it to run on my 2013 iMac would be a bonus (it's what I use normally for Minecraft since my laptop crashes occasionally)
I changed the format of the textures I listed might be corrupted. let me know if this works Phoxel Test.zip
I tried the shader you sent, and the results were identical unfortunately. I'm not going to put any more screenshots since it looks the exact same as 0.5.1 (unless you really really want to see it, it's not any different)
Hmm ok, I'm going to send a pack that directly outputs the PT part. I thought that was working, but maybe it's not. I'll get that to you no later than 4 PM today
Ok, TA no longer works but I'm just trying to pin down the issue Phoxel Test.zip
Ok, TA no longer works but I'm just trying to pin down the issue Phoxel Test.zip
As every good troubleshooter should.
Hopefully these screenshots will help:
Describe the bug Somewhat creepy lines appear all over the screen and grow in thickness as I look around, until the whole world goes totally black. The whole world, when not being obscured by these lines, is cast in a dark cyan/green color, where only the edges of the blocks have a lot of noise.
Steps to Reproduce n/a
Screenshots Specifications if it has to do with performance or crashes In this case it's not really performance nor crashes, but maybe you'll find it helpful. I'm getting about 35 FPS as it is right now, which is great to me.
Additional context On Ubuntu 24.04. Previous versions of Phoxel (last version tested was 0.4 Patch 2) would simply cause Iris to say "The shaderpack failed to load!"...
Also unrelated to this bug report, I really love the idea of this shader and can't wait to see it working on my machine!