Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
[ ] Yes:
[x] No
Other information:
There was an issue in the to_stl method, introduced in dessia_common 0.16.0
Traceback (most recent call last):
File "/home/gibertini/PycharmProjects/Dessia/venv/lib/python3.10/site-packages/IPython/core/interactiveshell.py", line 3508, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "<ipython-input-5-b76d18794df3>", line 1, in <module>
mesh5.to_stl("a")
File "/home/gibertini/PycharmProjects/Dessia/dessia_common/dessia_common/core.py", line 711, in to_stl
with open(filepath, 'wb', encoding='utf-8') as file:
ValueError: binary mode doesn't take an encoding argument
What kind of changes does this PR introduce?
[x] Bug fix
[ ] new features
[ ] performance
[ ] docs update
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
[ ] Yes:
[x] No
Other information:
There was an issue in the
to_stlmethod, introduced in dessia_common 0.16.0