What is the current behavior?
Today the shell3d.get_geo_lines is very complex. Here are some suggestions to refactor it.
before doing any refactor, it is recommended to create some tests for .geo files, so you are sure to have the same functionality at the and.
The first part of the code can be separated into one method. It searches to save all shell points on a list, as well as its face edges, in a way there is no repeated edges not matter the direction.
Then there is this part of the code, that can be simplified by updating the get_geo_lines method for each edge (circle, bspline, linesegment, arc, etc...) such that the get_geo_line_methods receives as arguments the points list, line_account and point_acount. Inside each edge class, there would be a get_geo_lines_tags to define what tags are appropriate for each edge. as the example shown below
Other improvements: simplify loops, eliminate unused enumerate...
I'm submitting a ...
What is the current behavior? Today the shell3d.get_geo_lines is very complex. Here are some suggestions to refactor it.
before doing any refactor, it is recommended to create some tests for .geo files, so you are sure to have the same functionality at the and.
The first part of the code can be separated into one method. It searches to save all shell points on a list, as well as its face edges, in a way there is no repeated edges not matter the direction.
Then there is this part of the code, that can be simplified by updating the get_geo_lines method for each edge (circle, bspline, linesegment, arc, etc...) such that the get_geo_line_methods receives as arguments the
pointslist,line_accountandpoint_acount. Inside each edge class, there would be aget_geo_lines_tagsto define what tags are appropriate for each edge. as the example shown belowOther improvements: simplify loops, eliminate unused enumerate...