Integrate occt - Githubissues

Dessia-tech / volmdlr

A python VOLume MoDeLeR computations-oriented with STEP support for import/export

GNU Lesser General Public License v2.1

26 stars 8 forks source link

Integrate occt #1315

Closed WirajanDASILVA closed 4 months ago

WirajanDASILVA commented 4 months ago

Please check if the PR fulfills these requirements
[X] The commit messages follows our guidelines (explicit, in english)
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[X] CHANGELOG.md has been updated
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
[ ] Bug fix:
[ ] New features:
[ ] Documentation
[ ] Optimization
Other information:

pgibertini commented 4 months ago

@WirajanDASILVA as we use OCP as wrapper for OCCT, is it preferable to name module from_ocp to_ocp? What do you think? It can help to avoid confusion, I think.

WirajanDASILVA commented 4 months ago

@WirajanDASILVA as we use OCP as wrapper for OCCT, is it preferable to name module from_ocp to_ocp? What do you think? It can help to avoid confusion, I think.

Yes, you're right. sorry, I saw your comment only after merging the PR. I do that in the next one.