search

DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.08k stars 641 forks source link

is:wishlist not matching on Belisarius-D #10256

Closed philkernick closed 4 months ago

philkernick commented 9 months ago

DIM Version

current beta

Browser Details

chrome

OS Details

Windows 11

Describe the bug

I have a Belisarius-D that has a 5/5 match with a wishlist role.

dimwishlist:item=2313726158&perks=839105230,1561002382,3619207468,460017080,3465198467

image

image

However there is no wishlist thumbs up on the item, and it is not selected by is:wishlist.

image

Logs

No response

bhollis commented 9 months ago

Can you share your profile export? Are you using the default voltron wishlist?

philkernick commented 9 months ago

Yes, default voltron wishlist. Not sure how to share a profile export.

The only thing I can see that is different about that weapon is that the 5th column perk is in the wishlist. And it's the only weapon I can find that the 5th column perk is selectable betwen an origin trait and a stock.

bhollis commented 9 months ago

A profile export can be saved from the Settings page in beta, at the bottom.

philkernick commented 9 months ago

Profile attached.
profile-data.json

bhollis commented 5 months ago

I loaded up the profile export, and I see two Belisarius-D that both match the wish list and have a thumbs up. Are you still seeing this issue?

philkernick commented 5 months ago

I only have one Belisarius-D, which is strange. But yes, the issue remains, and it continues to be the only weapon that has this problem. Current beta.

bhollis commented 5 months ago

Hmm, interesting. I've got the default Voltron list loaded, and with your profile info from February I see two Belisarius, both of which have a thumbs up (one is masterworked and one is not).

For fun, can you go to Settings, uncheck the default Voltron wishlist, and re-check it?

philkernick commented 5 months ago

I unchecked Voltron, clicked clear wishlist, then recheckedc Voltron. Same problem. All the other wishlist items are correct, but not Belisarius.

And I really only have one of them.

image

delphiactual commented 5 months ago

submit a new profile data

philkernick commented 5 months ago

New profile attached. profile-data.json

bhollis commented 5 months ago

Loading that profile, I see this:

Screenshot 2024-05-25 at 11 46 55 AM
bhollis commented 5 months ago

Oh, interesting, that seems to be matching from the Just Another Team wishlist. Just voltron doesn't match.

bhollis commented 5 months ago

OK, solved:

https://github.com/48klocs/dim-wish-list-sources/blob/f7414f3a29237eb8f37e506f2372ae6f36497c6e/PandaPaxxy/panda_s23_vendor.txt#L89-L220

The PandaPaxxy rolls for Belisarius-D specify that the roll must include Composite Stock AND Hand-Laid Stock AND Short-Action Stock. Obviously, that's impossible. @48klocs it looks like we need some validation on these rolls.

bhollis commented 4 months ago

Closing, see linked issue https://github.com/48klocs/dim-wish-list-sources/issues/189