search

DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.07k stars 644 forks source link

`is:dupe` should not count ITL weapons as duplicate from original #10321

Open Revadike opened 4 months ago

Revadike commented 4 months ago

Proposed change

Adept and non-adept weapons share the same origin trait and perk pool. Their only difference is the adept weapon mod. And for crafted weapons vs non-crafted, their only difference is possible enhanced perks. I'm glad they are counted as dupe, as they should.

These reprised weapons from ITL are mostly wildly different, though, as opposed to their original counterparts. They have different perk pools and different origin traits. I would not consider them the same/dupe. Therefore, is:dupe should not count them as such.

How does this fit into your workflow?

is:dupe is an important filter to me to decide what to dismantle, and this suggested change would more accurately reflect its intended meaning imo.

robojumper commented 4 months ago

Linking #9906

bhollis commented 3 months ago

I understand the complaint, but the difference should be readily apparent in the Compare page, right? You're not likely to get confused about which is which.

Revadike commented 3 months ago

It confuses my junk filter