DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.07k stars 642 forks source link

Swipe-to-dismiss on sheets can sometimes dismiss the parent sheet #10417

Open bhollis opened 5 months ago

bhollis commented 5 months ago

We've had multiple reports that people who are vigorously scrolling in a scrollable sheet will see that sheet dismiss - and dismiss the parent sheet as well. The common complaint seems to be the loadout editor and the mod selection sheet - people scroll mods and it dismisses the loadout sheet entirely, losing the in-progress loadout. This is clearly a bug but it has been hard to reproduct.

Linking #9903

ryan-rushton commented 5 months ago

I took a stab at reproducing it in the PWA and had no luck. Any inclination of apple vs android phones and or browsers?

bhollis commented 5 months ago

We've had reports from both but I can't reproduce on iPhone. I bought a Samsung phone to try and see if that's easier to repro on.

ryan-rushton commented 5 months ago

The only think I could see as a maybe was the velocity capture point where we hide the sheet if the downward velocity is fast enough. It is possible to drag the sheet close from clicking anywhere as the drag handle is on the container. I could actually get that to trigger and close the sheet via dragging an item in it, but I couldn't replicate the behaviour reported exactly. I had to be very deliberate and it also only closed the mod sheet (I was using edit loadout + add mods).

bhollis commented 5 months ago

Yeah, I'm not as worried about "it's too easy to close the sheet", I'm worried about closing one sheet also closing its parent.

ryan-rushton commented 5 months ago

Yeah agreed