DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.08k stars 641 forks source link

Sorting in the Organizer view for text fields no longer puts blanks at the top when sorted "Ascending" / alphabetically #10694

Closed JustTooKrul closed 2 months ago

JustTooKrul commented 2 months ago

DIM Version

Version 8.33.1.3545 (beta), built on 8/20/2024, 3:03:19 PM

Browser Details

Multiple; Chrome Version 104.0.5112.79 (Official Build) (64-bit); Chromium Version 123.0.6282.0 (Developer Build) (64-bit); Librewolf 120.0.1-1

OS Details

Windows 10

Describe the bug

Using the Organizer tab, when I sort by "Notes" anything without a note shows up at the bottom of the list. For years, sorting by "Notes" would put blank notes at the top when sorting alphabetically (just giving them an ordinal value of some variety). Now, sorting either way only sorts the items with the notes filled in. This behavior must have changed very recently since it behaves differently in the non-beta build. I also checked the DIM Changes and didn't see anything in the last week (I think builds are pushed from Beta to the main app weekly?) and this behavior changed in the last 24 hours and the only change I see is 8.33.1 (2024-08-20) Fixed the symbol picker displaying in the wrong part of the screen.

I've attached screenshots of the current beta DIM build sorted both ways and the item with no note yet filled in stays at the bottom, both times, and a screenshot of the current main DIM build where it sorts correctly with the item with no note filled in sorting according to the sorting order.

I should also note that the beta build of DIM treats blanks as sortable vs. the odd behavior for nothing filled in. DIM Sort Working (Current Main Build) (2 of 2) DIM Sort Working (Current Main Build) (1 of 2)

DIM Bug - Sorting With Blanks Always on Bottom (1 of 2) DIM Bug - Sorting With Blanks Always on Bottom (2 of 2)

Logs

[app] DIM v8.33.1.3545 (beta) - Please report any errors to https://www.github.com/DestinyItemManager/DIM/issues
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
www.googletagmanager.com/gtag/js?id=G-MYWW38Z3LR:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
console.ts:40 Browser chrome 104 is not supported by DIM. Supported browsers: Array(60)
(anonymous) @ console.ts:40
console.ts:40 [dim sync] globalSettings Object
console.ts:40 [dim sync] Saving profile data to IDB
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
console.ts:40 [wishlist] Discarded 62980 duplicate rolls from wish list https://raw.githubusercontent.com/48klocs/dim-wish-list-sources/master/voltron.txt
(anonymous) @ console.ts:40
console.ts:40 [wishlist] Discarded 431 duplicate rolls from wish list https://raw.githubusercontent.com/48klocs/dim-wish-list-sources/master/AyyItsChevy/super_pog_s15.txt
(anonymous) @ console.ts:40
console.ts:40 [wishlist] Discarded 174 duplicate rolls from wish list https://raw.githubusercontent.com/Gleaux/wish-list/main/drew_gleaux_wishlist.txt
(anonymous) @ console.ts:40
console.ts:40 [wishlist] Discarded 25053 duplicate rolls from wish list https://raw.githubusercontent.com/dsf000z/JAT-wishlists-bundler/main/bundles/DIM-strict/just-another-team-mnk.txt
(anonymous) @ console.ts:40
log.ts:59 [wishlist] Parse wish list: 873.3330078125 ms
console.ts:40 [d2-stores] No cached profile, using profile from Bungie.net which is 117.765s old.
console.ts:40 [dim sync] Saving profile data to IDB
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
log.ts:59 [manifest] Load manifest: 4531.635009765625 ms
log.ts:59 [d2-stores] Process inventory: 132.593017578125 ms
log.ts:59 [d2-stores] Inventory state update: 24.557861328125 ms
injected.js:42 [USO] Button detection aborting due to timeout.
console.ts:40 [d2-stores] Profile from Bungie.net is is 121.502s old, which is the same age as the cached profile. Skipping update.
console.ts:40 [manifest] Successfully stored manifest file.
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
injected.js:42 [USO] Button detection aborting due to timeout.
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
3injected.js:42 [USO] Button detection aborting due to timeout.
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
console.ts:40 [dim sync] Saving profile data to IDB
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
injected.js:42 [USO] Button detection aborting due to timeout.
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
injected.js:42 [USO] Button detection aborting due to timeout.
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
2injected.js:42 [USO] Button detection aborting due to timeout.
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
console.ts:40 [dim sync] Saving profile data to IDB
console.ts:40 [dim sync] Flushing queue of 1 updates
console.ts:40 [dim sync] tag Success 6917530041879592118: infuse/#Infuse => undefined/null Object
console.ts:40 [dim sync] Saving profile data to IDB
sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0:1          Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
console.ts:40 [dim sync] Saving profile data to IDB
console.ts:40 [d2-stores] Profile from Bungie.net is is 1.688s old, while the cached profile is 1580.856s old. Using the new profile from Bungie.net.
log.ts:59 [d2-stores] Process inventory: 68.530029296875 ms
log.ts:59 [d2-stores] Inventory state update: 23.47900390625 ms
fetch.ts:50          POST https://sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0 net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ fetch.ts:50
(anonymous) @ base.ts:78
add @ promisebuffer.ts:49
send @ base.ts:94
sendEnvelope @ baseclient.ts:567
_flushOutcomes @ baseclient.ts:922
(anonymous) @ client.ts:68
console.ts:40 [d2-stores] Profile from Bungie.net is is 5.074s old, while the cached profile is 57.715s old. Using the new profile from Bungie.net.
log.ts:59 [d2-stores] Process inventory: 64.18310546875 ms
log.ts:59 [d2-stores] Inventory state update: 45.053955078125 ms
fetch.ts:50          POST https://sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0 net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ fetch.ts:50
(anonymous) @ base.ts:78
add @ promisebuffer.ts:49
send @ base.ts:94
sendEnvelope @ baseclient.ts:567
_flushOutcomes @ baseclient.ts:922
(anonymous) @ client.ts:68
console.ts:40 [d2-stores] Profile from Bungie.net is is 23.431s old, while the cached profile is 239.384s old. Using the new profile from Bungie.net.
log.ts:59 [d2-stores] Process inventory: 63.3759765625 ms
log.ts:59 [d2-stores] Inventory state update: 22.137939453125 ms
fetch.ts:50          POST https://sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0 net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ fetch.ts:50
(anonymous) @ base.ts:78
add @ promisebuffer.ts:49
send @ base.ts:94
sendEnvelope @ baseclient.ts:567
sendSession @ baseclient.ts:376
captureSession @ baseclient.ts:240
g @ exports.ts:335
h @ exports.ts:314
f @ exports.ts:291
(anonymous) @ sdk.ts:328
l @ handlers.ts:54
(anonymous) @ history.ts:56
replace @ history.ts:676
(anonymous) @ hooks.tsx:243
onSelection @ Organizer.tsx:104
(anonymous) @ ItemTypeSelector.tsx:350
onClick @ ItemTypeSelector.tsx:384
Ne @ react-dom.production.min.js:54
Ue @ react-dom.production.min.js:54
Be @ react-dom.production.min.js:55
Fr @ react-dom.production.min.js:105
Vr @ react-dom.production.min.js:106
(anonymous) @ react-dom.production.min.js:117
cu @ react-dom.production.min.js:273
Ie @ react-dom.production.min.js:52
$r @ react-dom.production.min.js:109
Yt @ react-dom.production.min.js:74
qt @ react-dom.production.min.js:73
o @ helpers.ts:98
fetch.ts:50          POST https://sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0 net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ fetch.ts:50
(anonymous) @ base.ts:78
add @ promisebuffer.ts:49
send @ base.ts:94
sendEnvelope @ baseclient.ts:567
sendSession @ baseclient.ts:376
captureSession @ baseclient.ts:240
g @ exports.ts:335
m @ exports.ts:353
(anonymous) @ sdk.ts:329
l @ handlers.ts:54
(anonymous) @ history.ts:56
replace @ history.ts:676
(anonymous) @ hooks.tsx:243
onSelection @ Organizer.tsx:104
(anonymous) @ ItemTypeSelector.tsx:350
onClick @ ItemTypeSelector.tsx:384
Ne @ react-dom.production.min.js:54
Ue @ react-dom.production.min.js:54
Be @ react-dom.production.min.js:55
Fr @ react-dom.production.min.js:105
Vr @ react-dom.production.min.js:106
(anonymous) @ react-dom.production.min.js:117
cu @ react-dom.production.min.js:273
Ie @ react-dom.production.min.js:52
$r @ react-dom.production.min.js:109
Yt @ react-dom.production.min.js:74
qt @ react-dom.production.min.js:73
o @ helpers.ts:98
fetch.ts:50          POST https://sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0 net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ fetch.ts:50
(anonymous) @ base.ts:78
add @ promisebuffer.ts:49
send @ base.ts:94
sendEnvelope @ baseclient.ts:567
sendSession @ baseclient.ts:376
captureSession @ baseclient.ts:240
g @ exports.ts:335
h @ exports.ts:314
f @ exports.ts:291
(anonymous) @ sdk.ts:328
l @ handlers.ts:54
(anonymous) @ history.ts:56
replace @ history.ts:676
(anonymous) @ hooks.tsx:243
onSelection @ Organizer.tsx:104
(anonymous) @ ItemTypeSelector.tsx:350
onClick @ ItemTypeSelector.tsx:384
Ne @ react-dom.production.min.js:54
Ue @ react-dom.production.min.js:54
Be @ react-dom.production.min.js:55
Fr @ react-dom.production.min.js:105
Vr @ react-dom.production.min.js:106
(anonymous) @ react-dom.production.min.js:117
cu @ react-dom.production.min.js:273
Ie @ react-dom.production.min.js:52
$r @ react-dom.production.min.js:109
Yt @ react-dom.production.min.js:74
qt @ react-dom.production.min.js:73
o @ helpers.ts:98
fetch.ts:50          POST https://sentry.io/api/279673/envelope/?sentry_key=1367619d45da481b8148dd345c1a1330&sentry_version=7&sentry_client=sentry.javascript.react%2F8.26.0 net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ fetch.ts:50
(anonymous) @ base.ts:78
add @ promisebuffer.ts:49
send @ base.ts:94
sendEnvelope @ baseclient.ts:567
sendSession @ baseclient.ts:376
captureSession @ baseclient.ts:240
g @ exports.ts:335
m @ exports.ts:353
(anonymous) @ sdk.ts:329
l @ handlers.ts:54
(anonymous) @ history.ts:56
replace @ history.ts:676
(anonymous) @ hooks.tsx:243
onSelection @ Organizer.tsx:104
(anonymous) @ ItemTypeSelector.tsx:350
onClick @ ItemTypeSelector.tsx:384
Ne @ react-dom.production.min.js:54
Ue @ react-dom.production.min.js:54
Be @ react-dom.production.min.js:55
Fr @ react-dom.production.min.js:105
Vr @ react-dom.production.min.js:106
(anonymous) @ react-dom.production.min.js:117
cu @ react-dom.production.min.js:273
Ie @ react-dom.production.min.js:52
$r @ react-dom.production.min.js:109
Yt @ react-dom.production.min.js:74
qt @ react-dom.production.min.js:73
o @ helpers.ts:98
injected.js:42 [USO] Button detection aborting due to timeout.
bhollis commented 2 months ago

This was changed in https://github.com/DestinyItemManager/DIM/pull/10680, which merged 2 weeks ago.

I'm not sure whether to restore the original behavior or leave it this way. The intention is that when sorting, unset values are always at the end, so you can sort only the items that actually have a value one way or the other.

JustTooKrul commented 2 months ago

Seems like there is an issue with filtering vs. sorting. I understand wanting to filter out unset values, but when I sort a list and some items show up at the end and I reverse the sort then it is very counter-intuitive to not have the order of the entire list reverse. Seems like this is more likely to lead to confusion and people missing items entirely, especially since it's at the end and out of sight.

On Fri, Aug 23, 2024 at 9:37 PM Ben Hollis @.***> wrote:

This was changed in #10680 https://github.com/DestinyItemManager/DIM/pull/10680

I'm not sure whether to restore the original behavior or leave it this way. The intention is that when sorting, unset values are always at the end, so you can sort only the items that actually have a value one way or the other.

— Reply to this email directly, view it on GitHub https://github.com/DestinyItemManager/DIM/issues/10694#issuecomment-2307842365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQERZTPJEF2EDP5XVHNYKUTZS6TRVAVCNFSM6AAAAABNAONUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHA2DEMZWGU . You are receiving this because you authored the thread.Message ID: @.***>

bhollis commented 2 months ago

It's not really a matter of filtering vs. sorting - it's a matter of sorting rows that have relevance to the search and not including things that are not relevant.

That said, I'll change this back since I don't care.

JustTooKrul commented 2 months ago

Maybe an option in the "settings" could allow someone to specify if the items with no notes should be sorted or ignored and appended? Not sure how much work that is or how much added complexity that introduces, but just a thought. Not trying to create more work, but took me a while and some time in the Discord to realize why a bunch of my items weren't showing up in the Organizer, so the current behavior seems a bit counter-intuitive.

On Tue, Aug 27, 2024 at 5:24 PM Ben Hollis @.***> wrote:

It's not really a matter of filtering vs. sorting - it's a matter of sorting rows that have relevance to the search and not including things that are not relevant.

That said, I'll change this back since I don't care.

— Reply to this email directly, view it on GitHub https://github.com/DestinyItemManager/DIM/issues/10694#issuecomment-2313129557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQERZTNMRKLSV7BY5M7PS2TZTSY3PAVCNFSM6AAAAABNAONUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGEZDSNJVG4 . You are receiving this because you authored the thread.Message ID: @.***>

bhollis commented 2 months ago

https://github.com/DestinyItemManager/DIM/wiki/Frequently-Requested-Features#add-an-option-for-it

JustTooKrul commented 2 months ago

Makes sense. Didn't mean to create extra work for you guys!

On Tue, Aug 27, 2024 at 11:24 PM Ben Hollis @.***> wrote:

https://github.com/DestinyItemManager/DIM/wiki/Frequently-Requested-Features#add-an-option-for-it

— Reply to this email directly, view it on GitHub https://github.com/DestinyItemManager/DIM/issues/10694#issuecomment-2313745385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQERZTOTK36RIZMQB67HHSLZTUDBVAVCNFSM6AAAAABNAONUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTG42DKMZYGU . You are receiving this because you authored the thread.Message ID: @.***>