Closed JustTooKrul closed 2 weeks ago
bhollis
commented
2 weeks ago This was changed in https://github.com/DestinyItemManager/DIM/pull/10680, which merged 2 weeks ago.
I'm not sure whether to restore the original behavior or leave it this way. The intention is that when sorting, unset values are always at the end, so you can sort only the items that actually have a value one way or the other.
JustTooKrul
commented
2 weeks ago Seems like there is an issue with filtering vs. sorting. I understand wanting to filter out unset values, but when I sort a list and some items show up at the end and I reverse the sort then it is very counter-intuitive to not have the order of the entire list reverse. Seems like this is more likely to lead to confusion and people missing items entirely, especially since it's at the end and out of sight.
On Fri, Aug 23, 2024 at 9:37 PM Ben Hollis @.***> wrote:
This was changed in #10680 https://github.com/DestinyItemManager/DIM/pull/10680
I'm not sure whether to restore the original behavior or leave it this way. The intention is that when sorting, unset values are always at the end, so you can sort only the items that actually have a value one way or the other.
— Reply to this email directly, view it on GitHub https://github.com/DestinyItemManager/DIM/issues/10694#issuecomment-2307842365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQERZTPJEF2EDP5XVHNYKUTZS6TRVAVCNFSM6AAAAABNAONUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHA2DEMZWGU . You are receiving this because you authored the thread.Message ID: @.***>
bhollis
commented
2 weeks ago It's not really a matter of filtering vs. sorting - it's a matter of sorting rows that have relevance to the search and not including things that are not relevant.
That said, I'll change this back since I don't care.
JustTooKrul
commented
2 weeks ago Maybe an option in the "settings" could allow someone to specify if the items with no notes should be sorted or ignored and appended? Not sure how much work that is or how much added complexity that introduces, but just a thought. Not trying to create more work, but took me a while and some time in the Discord to realize why a bunch of my items weren't showing up in the Organizer, so the current behavior seems a bit counter-intuitive.
On Tue, Aug 27, 2024 at 5:24 PM Ben Hollis @.***> wrote:
It's not really a matter of filtering vs. sorting - it's a matter of sorting rows that have relevance to the search and not including things that are not relevant.
That said, I'll change this back since I don't care.
— Reply to this email directly, view it on GitHub https://github.com/DestinyItemManager/DIM/issues/10694#issuecomment-2313129557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQERZTNMRKLSV7BY5M7PS2TZTSY3PAVCNFSM6AAAAABNAONUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGEZDSNJVG4 . You are receiving this because you authored the thread.Message ID: @.***>
bhollis
commented
2 weeks ago JustTooKrul
commented
2 weeks ago Makes sense. Didn't mean to create extra work for you guys!
On Tue, Aug 27, 2024 at 11:24 PM Ben Hollis @.***> wrote:
https://github.com/DestinyItemManager/DIM/wiki/Frequently-Requested-Features#add-an-option-for-it
— Reply to this email directly, view it on GitHub https://github.com/DestinyItemManager/DIM/issues/10694#issuecomment-2313745385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQERZTOTK36RIZMQB67HHSLZTUDBVAVCNFSM6AAAAABNAONUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTG42DKMZYGU . You are receiving this because you authored the thread.Message ID: @.***>
DIM Version
Version 8.33.1.3545 (beta), built on 8/20/2024, 3:03:19 PM
Browser Details
Multiple; Chrome Version 104.0.5112.79 (Official Build) (64-bit); Chromium Version 123.0.6282.0 (Developer Build) (64-bit); Librewolf 120.0.1-1
OS Details
Windows 10
Describe the bug
Using the Organizer tab, when I sort by "Notes" anything without a note shows up at the bottom of the list. For years, sorting by "Notes" would put blank notes at the top when sorting alphabetically (just giving them an ordinal value of some variety). Now, sorting either way only sorts the items with the notes filled in. This behavior must have changed very recently since it behaves differently in the non-beta build. I also checked the DIM Changes and didn't see anything in the last week (I think builds are pushed from Beta to the main app weekly?) and this behavior changed in the last 24 hours and the only change I see is 8.33.1 (2024-08-20) Fixed the symbol picker displaying in the wrong part of the screen.
I've attached screenshots of the current beta DIM build sorted both ways and the item with no note yet filled in stays at the bottom, both times, and a screenshot of the current main DIM build where it sorts correctly with the item with no note filled in sorting according to the sorting order.
I should also note that the beta build of DIM treats blanks as sortable vs. the odd behavior for nothing filled in.
Logs