DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.07k stars 643 forks source link

is:complete not working properly [3.0.3] #125

Closed m-s-y closed 8 years ago

m-s-y commented 9 years ago

DIM 3.0.3:

filter of is:complete is not returning all completed items. Screenshot attached shows that some items are properly identified as complete, but others are not.

I clicked on Oversoul Edict in the screenshot -- the pop-up shows that DIM identifies it with 331 attack, meaning it must be a complete weapon, yet it's not marked as visible.

I put yellow stars next to other items in my inventory that are also complete, yet not visible with this filter.

2015-05-15_14-17-42

It does appear that is:xpcomplete is working properly, though.

SunburnedGoose commented 9 years ago

Did you buy that hive disruptor perk?

m-s-y commented 9 years ago

yeah, but its Oversoul, not the broken Black Hammer one. even so, some of the "normal" weapons in my vault aren't triggering properly either

SunburnedGoose commented 9 years ago

Ok, I'll check it out. Looking at my Atheon's Epilogue, it shows 300, but the flag from Bungie says it's not complete. Gonna have to look at it to see if there is something else we're missing.

m-s-y commented 9 years ago

Ever notice that when you transfer some items back into inventory - even if they're complete - the in-game Destiny inventory marks some nodes as "new"? Could be a bungie API issue...

SunburnedGoose commented 9 years ago

Was this pre-patch or post-patch?

phatsk commented 9 years ago

Thought: "complete" may not be true until the Ascension tier comes in with HoW (or may just be buggy, and something they put off until HoW since the criteria will change anyways). Just about all legendaries will be able to ascend to higher attack values. Maybe also an API issue, as I do have that happen when an item will sometimes come across as "Unupgraded" until you view it

SunburnedGoose commented 9 years ago

Looks like the B.net update is changing our gear. All my guns are slowly becoming incomplete.

Might have to add a new feature is:ascended

m-s-y commented 9 years ago

FYI: both pre-and post 1.2.0 patch the behavior is the same. I just noticed they were updated, and so I grabbed the updated manifests from the Bungie API... likely this issue is related to the HoW release.

is:ascended sounds like it will be useful

m-s-y commented 9 years ago

Oops. Mis-clicked.

phatsk commented 9 years ago

Proposal:

Could we use notis as a negative match to existing searches? Or something similar.

SunburnedGoose commented 9 years ago

In the future, I see there being three states: is, not, indeterminate. If we visually represent these options, you would click once to select the filter to reduce, click again to reduce the opposite, and then click once more to clear the filter from the collection. On Sat, May 16, 2015 at 1:39 AM phatsk notifications@github.com wrote:

Proposal:

  • is:ascended
  • notis:ascended

Could we use notis as a negative match to existing searches? Or something similar.

— Reply to this email directly or view it on GitHub https://github.com/kyleshay/DIM/issues/125#issuecomment-102579565.

SunburnedGoose commented 9 years ago

As for your question, in the near term, I'm fine with is: and not: That feels the clearest. Now do we have to refactor all of the filters? On Sat, May 16, 2015 at 1:55 AM Rick Casey rick.casey@gmail.com wrote:

In the future, I see there being three states: is, not, indeterminate. If we visually represent these options, you would click once to select the filter to reduce, click again to reduce the opposite, and then click once more to clear the filter from the collection. On Sat, May 16, 2015 at 1:39 AM phatsk notifications@github.com wrote:

Proposal:

  • is:ascended
  • notis:ascended

Could we use notis as a negative match to existing searches? Or something similar.

— Reply to this email directly or view it on GitHub https://github.com/kyleshay/DIM/issues/125#issuecomment-102579565.

kyleshay commented 9 years ago

is this still an issue?

bhollis commented 8 years ago

This has all been fixed in #382.