Term usage: replace 'before' with 'undo'

DestinyItemManager / DIM

Destiny Item Manager

https://destinyitemmanager.com

MIT License

2.07k stars 644 forks source link

Term usage: replace 'before' with 'undo' #3576

Closed rentalhost closed 5 years ago

rentalhost commented 5 years ago

When we do some loadout action, is possible undo the effect. The term used is "before {name}", but I think that we should use "undo {name}" instead.

https://github.com/DestinyItemManager/DIM/blob/ee6611e501b263c3b2b9dd8f1d1d2deefb3eddcf/src/app/loadout/loadout.service.ts#L260-L270
https://crowdin.com/translate/destiny-item-manager/3/en-ptbr#1294

delphiactual commented 5 years ago

Why?

rentalhost commented 5 years ago

Ah, okay... Seems that this feature will not undo action as I have imaginated, but it will move previous items to main slot again. So I guess that I can only improve portuguese translation. Do you agree @duckmanBR?