search

DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.07k stars 642 forks source link

Vaulting shaders from the postmaster does not function correctly #6380

Closed Arkhaeon closed 5 months ago

Arkhaeon commented 3 years ago

What version of DIM are you using? Version 6.44.0.1000112 (beta), built on 23/12/2020, 17:33:45 This error has occurred in previous versions of DIM as well.

What Browser and OS are you using? Chrome Version 87.0.4280.88 (Official Build) (64-bit) Windows 10

Describe the bug and how to make it happen Pulling shaders directly from the postmaster to the vault does not work. Shaders appear in the vault in DIM but get stuck in the inventory in-game. DIM corrects this after a refresh.

Include devtools console logs

[move] Pull 1 Vanguard Metallic Shaders to Vault from Postmaster
instrument.ts:129 [move] Pull 1 Vanguard Metallic Shaders to Vault from Postmaster
instrument.ts:158 POST https://www.bungie.net/Platform/Destiny2/Actions/Items/PullFromPostmaster/ 500
(anonymous) @ instrument.ts:158
u @ authenticated-fetch.ts:50
async function (async)
u @ authenticated-fetch.ts:33
processQueue @ rate-limiter.ts:66
add @ rate-limiter.ts:43
(anonymous) @ rate-limiter.ts:116
(anonymous) @ http-client.ts:123
(anonymous) @ http-client.ts:157
(anonymous) @ http-client.ts:189
(anonymous) @ bungie-service-helper.ts:98
l @ api.js:109
f @ destiny2-api.ts:269
(anonymous) @ item-move-service.ts:332
(anonymous) @ index.js:8
dispatch @ redux.js:638
(anonymous) @ item-move-service.ts:920
async function (async)
(anonymous) @ item-move-service.ts:880
(anonymous) @ index.js:8
I.b @ ItemMoveLocations.tsx:52
onClick @ ItemMoveLocations.tsx:334
Ze @ react-dom.production.min.js:52
$e @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
kr @ react-dom.production.min.js:100
Er @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Me @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Dr @ react-dom.production.min.js:105
Xt @ react-dom.production.min.js:75
Yt @ react-dom.production.min.js:74
(anonymous) @ scheduler.production.min.js:18
Bo @ react-dom.production.min.js:122
_e @ react-dom.production.min.js:292
Kt @ react-dom.production.min.js:73
r @ helpers.ts:87
instrument.ts:129 [move] Item Vanguard Metallic was not found - pretending the move succeeded
(anonymous) @ instrument.ts:129
o @ log.ts:22
(anonymous) @ item-move-service.ts:342
async function (async)
(anonymous) @ item-move-service.ts:332
(anonymous) @ index.js:8
dispatch @ redux.js:638
(anonymous) @ item-move-service.ts:920
async function (async)
(anonymous) @ item-move-service.ts:880
(anonymous) @ index.js:8
I.b @ ItemMoveLocations.tsx:52
onClick @ ItemMoveLocations.tsx:334
Ze @ react-dom.production.min.js:52
$e @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
kr @ react-dom.production.min.js:100
Er @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Me @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Dr @ react-dom.production.min.js:105
Xt @ react-dom.production.min.js:75
Yt @ react-dom.production.min.js:74
(anonymous) @ scheduler.production.min.js:18
Bo @ react-dom.production.min.js:122
_e @ react-dom.production.min.js:292
Kt @ react-dom.production.min.js:73
r @ helpers.ts:87
instrument.ts:129 [move] Moved item not found undefined
(anonymous) @ instrument.ts:129
o @ log.ts:22
(anonymous) @ reducer.ts:311
(anonymous) @ reducer.ts:76
(anonymous) @ immerClass.ts:97
E @ reducer.ts:76
(anonymous) @ redux.js:459
(anonymous) @ reducers.ts:28
g @ redux.js:213
(anonymous) @ index.js:11
dispatch @ redux.js:638
(anonymous) @ item-move-service.ts:111
(anonymous) @ index.js:8
dispatch @ redux.js:638
(anonymous) @ item-move-service.ts:348
async function (async)
(anonymous) @ item-move-service.ts:332
(anonymous) @ index.js:8
dispatch @ redux.js:638
(anonymous) @ item-move-service.ts:920
async function (async)
(anonymous) @ item-move-service.ts:880
(anonymous) @ index.js:8
I.b @ ItemMoveLocations.tsx:52
onClick @ ItemMoveLocations.tsx:334
Ze @ react-dom.production.min.js:52
$e @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
kr @ react-dom.production.min.js:100
Er @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Me @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Dr @ react-dom.production.min.js:105
Xt @ react-dom.production.min.js:75
Yt @ react-dom.production.min.js:74
(anonymous) @ scheduler.production.min.js:18
Bo @ react-dom.production.min.js:122
_e @ react-dom.production.min.js:292
Kt @ react-dom.production.min.js:73
r @ helpers.ts:87
instrument.ts:129 [clicked item] https://data.destinysets.com/i/InventoryItem%3A2788911998 {owner: "vault", destinyVersion: 2, location: {…}, bucket: {…}, hash: 2788911998, …}
log.ts:44 Process inventory: 125.256103515625 ms
log.ts:44 Inventory state update: 153.486083984375 ms
instrument.ts:129 [clicked item] https://data.destinysets.com/i/InventoryItem%3A2788911998 {owner: "2305843009299246589", destinyVersion: 2, location: {…}, bucket: {…}, hash: 2788911998, …}ammoType: 0amount: 1availableMetricCategoryNodeHashes: undefinedbasePower: 0breakerType: nullbucket: {description: "Apply new colors and materials to compatible gear.", name: "Shaders", hash: 2973005342, hasTransferDestination: true, capacity: 50, …}canPullFromPostmaster: trueclassType: 3classTypeNameLocalized: "Any class"classified: falsecollectibleHash: 2333638028collectibleState: 0comparable: falsecomplete: falsedescription: "Your influence is undeniable.↵↵Apply this shader to your gear as a testament to the unity of the Vanguard."destinyVersion: 2displaySource: "If this shader is applied to an item and then the item is dismantled, the shader will be returned to your inventory."element: nullenergy: nullequipRequiredLevel: 0equipment: falseequipped: falseequippingLabel: undefinedhash: 2788911998hiddenOverlay: "/common/destiny2_content/icons/0669efb55951e8bc9e99f3989eacc861.png"hidePercentage: falseicon: "/common/destiny2_content/icons/217fa35c1efa0cfaea311d6cebee1ac2.jpg"iconOverlay: "/common/destiny2_content/icons/0669efb55951e8bc9e99f3989eacc861.png"id: "0"index: "0-t224"infusable: falseinfusionFuel: falseinfusionQuality: nullisEngram: falseisExotic: falseisVendorItem: falseitemCategoryHashes: (2) [41, 52]location: {description: "Apply new colors and materials to compatible gear.", name: "Shaders", hash: 2973005342, hasTransferDestination: true, capacity: 50, …}lockable: falselocked: falseloreHash: undefinedmasterwork: falsemasterworkInfo: nullmaxStackSize: 1000metricHash: undefinedmetricObjective: undefinedmissingSockets: falsename: "Vanguard Metallic"notransfer: falseobjectives: nullowner: "2305843009299246589"percentComplete: 0perks: nullplug: {energyCost: 0, costElementIcon: undefined}powerCap: nullpreviewVendor: 0primStat: nullpursuit: nullsecondaryIcon: undefinedsockets: nullsource: 1118966764stats: nulltaggable: truetalentGrid: nulltier: "Legendary"trackable: falsetracked: falsetype: "Shaders"typeName: "Shader"uniqueStack: false__proto__: Object
instrument.ts:129 [SW] Got server version {version: "6.44.0.1000112", buildTime: 1608707025681}

Pulling shader from postmaster to vault: image Shader appears in vault in DIM: image Shader is still actually in inventory and appears there in DIM after a refresh: image

bhollis commented 3 years ago

The key log entry is [move] Item Vanguard Metallic was not found - pretending the move succeeded

In this case the Bungie.net API threw an error, but we didn't log exactly what error was thrown.

philkernick commented 3 years ago

I suspect this is the same bug that caused #4652.

thebtm commented 3 years ago

With the new Shader System, is this still a bug or no longer required?

bhollis commented 3 years ago

Still a bug, it probably happens with other things that aren't shaders

lowPolySkeleton commented 5 months ago

I don't think this is possible anymore now that shaders aren't individual items.