search

DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.08k stars 641 forks source link

Incorrect magazine size calculation #6929

Closed Zeiin closed 3 years ago

Zeiin commented 3 years ago

What version of DIM are you using? Version 6.74.0 (release), built on 7/18/2021, 10:04:38 PM

What Browser and OS are you using? Chrome on Win10

Describe the bug and how to make it happen I set up my Uzume RR4 in game to use adept backup mag instead of backup mag. In game, this bumps the magazine up to 6, but DIM only displays 5. image

image

Note that in-game, hovering over Adept Mag when Backup mag is equip doesn't preview that the mag size will go up. Normally a small green arrow would appear near magazine to indicate the upcoming bump: image

nev-r commented 3 years ago

unfortunately this is just gonna be wrong sometimes. bungie's mag calculations are performed in game at runtime and a lot of API data is close but not quite right. for context,

uzume's raw magazine stat is 50 image

adept mag provides +40 image

and the statgroup curve, specifically says the result, 90, should give you a 5 bullet mag image