search

DestinyItemManager / DIM

Destiny Item Manager
https://destinyitemmanager.com
MIT License
2.07k stars 642 forks source link

Tweak stat color range #7202

Closed bhollis closed 4 months ago

bhollis commented 2 years ago

It'd be nice to have some more separation between the colors - today almost everything is red, then the very best are blue or green. One issue is that this isn't implemented as a smooth ramp, instead it's just sharp breakpoints.

bhollis commented 2 years ago

Naively using a smooth ramp instead of the steps we have today (which mark everything below 85th percentile red, and then have a few defined steps above that), looks like this:

image

kyleshay commented 2 years ago

It looks a lotttt better, but it may be difficult for some to quickly parse the more subtle variations. Could play w/ the ramp to make it more logarithmic / slightly less color steps?

Another (semi-related, ish... maybe better in it's own ticket) thought is we could set a default sort on the compare and highlight the background column of the original item you clicked (well, maybe not orange to conflict with the numbers.) I wonder if some may not know that the rows can be sorted?

Screen Shot 2021-11-11 at 7 52 59 PM
kyleshay commented 2 years ago

Could highlight just the lowest number with red, highest with blue and everything else non-color? I do like how it looks in the organizer view.

bhollis commented 2 years ago

For reference this is the original scale: dim-scale

And the new one is a bit closer to what people thought it was: