search

DestroyedClone / AncientScepter

ThinkInvis' ClassicItems' Ancient Scepter Port
0 stars 5 forks source link

Project Reference Issue #39

Closed DestroyedClone closed 1 year ago

DestroyedClone commented 1 year ago

Project/package uses old R2API references.

Fix: Update to latest references/r2api usage.

Causes issues with SS2 Thunderkit project:

it imports scepter to the thunderkit project, which already imports the proper r2api packages, so when scepter's dependencies are imported, the old r2api is there and you have duplicate references gotta delete it every time

yekoc commented 1 year ago

Sounds like thunderkit/ss2 issue but it's still simple to fix on scepter end/should probably be done anyways so might as well.

yekoc commented 1 year ago

Seems like the thunderkit manifest is the only place that actually uses old r2api (unless I'm missing it) (BepInDependency on the plugin also uses the old id but R2API.Core also uses it on the new setup so that shouldn't be a problem (though we should add the specific modules to the bepdep anyways.))

DestroyedClone commented 1 year ago

Fixed with https://github.com/DestroyedClone/AncientScepter/commit/20a3f02c3292ffd5628247e14f52ddb2254cd309