DestructHub / ProjectEuler

Polyglot solutions for www.projecteuler.net mathematical challenges
https://destructhub.github.io
MIT License
166 stars 45 forks source link

Problem037: Create pe037.py #200

Closed namannimmo10 closed 5 years ago

namannimmo10 commented 5 years ago

Another solution in python added

namannimmo10 commented 5 years ago

Thank you for your contributions ! Could you please rename your solution files to something like solution_1.py / solution_2etc... ? The stats.py only detect solutions following this naming standard

Sure, but some of the files are already there by that name

a-hilaly commented 5 years ago

You can increment the solution number. It should just start with solution_, for example solution_1.py solution_5.py solution_13.py etc... when solutions are slow you can use something like solution_slow_1.py

namannimmo10 commented 5 years ago

Okay!

On Sat, Aug 24, 2019 at 4:12 PM Amine notifications@github.com wrote:

You can increment the solution number. It should just start with solution_, for example solution_1.py solution_5.py solution_13.py etc... when solutions are slow you can use something like solution_slow_1.py

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DestructHub/ProjectEuler/pull/200?email_source=notifications&email_token=AKID5JNLOJEE2CYSNHAMDY3QGEF7TA5CNFSM4IPFZHVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B5ULA#issuecomment-524540460, or mute the thread https://github.com/notifications/unsubscribe-auth/AKID5JKWEJIKP34EYBTV2H3QGEF7TANCNFSM4IPFZHVA .

namannimmo10 commented 5 years ago

Check if the latest commit style is Okay?

On Sat, Aug 24, 2019 at 4:12 PM Amine notifications@github.com wrote:

You can increment the solution number. It should just start with solution_, for example solution_1.py solution_5.py solution_13.py etc... when solutions are slow you can use something like solution_slow_1.py

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DestructHub/ProjectEuler/pull/200?email_source=notifications&email_token=AKID5JNLOJEE2CYSNHAMDY3QGEF7TA5CNFSM4IPFZHVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B5ULA#issuecomment-524540460, or mute the thread https://github.com/notifications/unsubscribe-auth/AKID5JKWEJIKP34EYBTV2H3QGEF7TANCNFSM4IPFZHVA .

a-hilaly commented 5 years ago

I mean the python solution file, not the Pull Request title. In your branch you should rename the file name (for example rename Problem037/Python/pe037.py to Problem037/Python/solution_2.py ) . You'll have to recommit your changes and push again

ryukinix commented 5 years ago

Check if the latest commit style is Okay?

Take as example this PR that you wrote. This style it's ok for us.

ryukinix commented 5 years ago

Another suggestion: try to fix the other PRs already open instead opening new ones.