search

DestructHub / ProjectEuler

Polyglot solutions for www.projecteuler.net mathematical challenges
https://destructhub.github.io
MIT License
166 stars 45 forks source link

Problem 37: a new solution in c++ added. #222

Closed namannimmo10 closed 5 years ago

namannimmo10 commented 5 years ago

@rafaelcn Is that Okay now?

rafaelcn commented 5 years ago

@namannimmo10 regarding the curly brackets stuff everything is good. But there are those details I explained in the previous comment.

namannimmo10 commented 5 years ago

I don't think I can make this code more beautiful :p

rafaelcn commented 5 years ago

Resolve those issues and I will be happy to merge this :-)

rafaelcn commented 5 years ago

There's still one point that I'd like to talk you about that I missed in the last review.

namannimmo10 commented 5 years ago

There's still one point that I'd like to talk you about that I missed in the last review.

sure. What is it?

namannimmo10 commented 5 years ago

LGTM

Can I become a maintainer of this repository now? I'm in the top 3 of the contributor's list

rafaelcn commented 5 years ago

@namannimmo10 me and @ryukinix would have to ponder about it.